[PATCH V3 4/7] dmaengine/dw_dmac: Enable resubmission from callback routine.

Russell King - ARM Linux linux at arm.linux.org.uk
Thu Apr 28 13:12:27 EDT 2011


On Wed, Apr 27, 2011 at 03:06:46PM +0530, Viresh Kumar wrote:
>  static void
>  dwc_descriptor_complete(struct dw_dma_chan *dwc, struct dw_desc *desc,
> -		bool callback_required)
> +		bool callback_required, unsigned long flags)
>  {
...
>  	if (callback_required) {
> +		spin_unlock_irqrestore(&dwc->lock, flags);
>  		if (callback)
>  			callback(param);
> +		spin_lock_irqsave(&dwc->lock, flags);

Again, this isn't really on.  It seems to me that this code needs some
serious reworking.



More information about the linux-arm-kernel mailing list