[PATCH] Trivial: ARM: pxa168: Bug fix - correct UART DMA channels

Eric Miao eric.y.miao at gmail.com
Wed Apr 27 03:28:19 EDT 2011


On Wed, Apr 27, 2011 at 12:41 PM, Tanmay Upadhyay
<tanmay.upadhyay at einfochips.com> wrote:
> On Tuesday 04 January 2011 11:37 AM, Tanmay Upadhyay wrote:
>
> According to ARMADA_16x_Software_Manual.pdf, DMA channels for
> UART1 are 19, 20 and DMA channels for UART2 are 21, 22.
>
> It's of little significance for now as the PXA UART driver
> doesn't use DMA as of now.
>
> Signed-off-by: Tanmay Upadhyay <tanmay.upadhyay at einfochips.com>
> ---
>  arch/arm/mach-mmp/pxa168.c |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm/mach-mmp/pxa168.c b/arch/arm/mach-mmp/pxa168.c
> index 72b4e76..7564739 100644
> --- a/arch/arm/mach-mmp/pxa168.c
> +++ b/arch/arm/mach-mmp/pxa168.c
> @@ -147,8 +147,8 @@ void pxa168_clear_keypad_wakeup(void)
>  }
>
>  /* on-chip devices */
> -PXA168_DEVICE(uart1, "pxa2xx-uart", 0, UART1, 0xd4017000, 0x30, 21, 22);
> -PXA168_DEVICE(uart2, "pxa2xx-uart", 1, UART2, 0xd4018000, 0x30, 23, 24);
> +PXA168_DEVICE(uart1, "pxa2xx-uart", 0, UART1, 0xd4017000, 0x30, 19, 20);
> +PXA168_DEVICE(uart2, "pxa2xx-uart", 1, UART2, 0xd4018000, 0x30, 21, 22);
>  PXA168_DEVICE(twsi0, "pxa2xx-i2c", 0, TWSI0, 0xd4011000, 0x28);
>  PXA168_DEVICE(twsi1, "pxa2xx-i2c", 1, TWSI1, 0xd4025000, 0x28);
>  PXA168_DEVICE(pwm1, "pxa168-pwm", 0, NONE, 0xd401a000, 0x10);
>
> Is there anything wrong with the patch? Any suggestions please?
>

Hi Tanmay,

Nothing wrong with the patch. Sorry it was kept in the bottom of my
mail box for such a long time.

Jason &  Haojian,

I need your double-check and Ack. Thanks.

> Thanks,
>
> Tanmay
>



More information about the linux-arm-kernel mailing list