[PATCH 14/14] at91: move clock subsystem init to soc generic init

[Jean-Christophe PLAGNIOL-VILLARD]

On 16:32 Tue 26 Apr     , Ryan Mallon wrote:
> On 04/26/2011 04:13 PM, Jean-Christophe PLAGNIOL-VILLARD wrote:
> > On 15:13 Tue 26 Apr     , Ryan Mallon wrote:
> >> On 04/26/2011 01:11 PM, Jean-Christophe PLAGNIOL-VILLARD wrote:
> >>> Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD <plagnioj at jcrosoft.com>
> >>> Cc: Nicolas Ferre <nicolas.ferre at atmel.com>
> >>> Cc: Patrice Vilchez <patrice.vilchez at atmel.com>
> >>
> >> <snip>
> >>
> >>>  /* --------------------------------------------------------------------
> >>> diff --git a/arch/arm/mach-at91/soc.c b/arch/arm/mach-at91/soc.c
> >>> index c82d219..2d4e415 100644
> >>> --- a/arch/arm/mach-at91/soc.c
> >>> +++ b/arch/arm/mach-at91/soc.c
> >>> @@ -115,7 +115,10 @@ void __init at91_initialize(unsigned long main_clock)
> >>>  
> >>>  	pr_info("AT91: detected soc: %s\n", current_soc.name);
> >>>  
> >>> -	current_soc.init(main_clock);
> >>> +	current_soc.init();
> >>
> >> I think this patch should go near the beginning of the series so that
> >> current_soc.init never needs to take an argument.
> > no until you factorize the at91_init_clock you do need it
> 
> That's my point. If you move this patch earlier so that at91_init_clock
> is factorised early then current_soc.init won't ever need the argument.
to do this I need to move the gpio and the cloock register
and to do so I need to switch to clkdev and early device

if I move the gpio I need do to much more changesets
so keep the change less intrusive is better

Best Regards,
J.