[RFC PATCH 00/18] OMAP: GPIO: cleanup GPIO driver
charu at ti.com
Mon Apr 25 10:03:51 EDT 2011
Thanks for your comments.
On Sat, Apr 23, 2011 at 04:04, Kevin Hilman <khilman at ti.com> wrote:
> Hi Charu,
> Charulatha V <charu at ti.com> writes:
>> Modifies the OMAP GPIO driver to avoid usage of cpu_is* checks
>> for different OMAP architectures. This is done by moving some
>> architecture specific code to mach-omap* and call them from
>> plat-omap* using function pointers. Also remove the register offset
>> macros from OMAP GPIO driver and handle the same in mach-omap*.
> Thanks for working on this cleanup, this driver really needs a cleanup.
> You've hit on all the main areas for cleanup, but unfortunately, it's
> not really going in the direction I was hoping. Rather than moving code
> into the SoC specific parts, I was hoping to generalize the driver such
> that SoC-specific code would just pass in register offsets/options into
> the common driver. Your current approach isn't really reducing code,
> it's just moving it around.
> I had started on a similar cleanup as well, and will post that series
> shortly to demonstrate the direction I think the cleanups should be
> going. I've tackled most of the same functions/areas that you have
> (except the IRQ triggering stuff), but have a rather different approach.
> I'll get to the IRQ triggering stuff next (after going on vacation for a
> week), but feel free to build on top of my series if you like.
Sure. I will wait for your series.
> The direction I'd like to go is towards having a generalized driver that
> can not only work across all OMAP SoCs, but also hopefully towards
> something that can be shared with other SoCs as well. Of course, the
> first step is cleaning up the OMAP driver, but the next step will be
> looking for other areas of consolidation. Towards that end, I'm also
> working towards converting the GPIO IRQs in this driver to use the new
> generic IRQ chip infrastructure posted by Thomas Gleixner. In my
> series, you'll see that I started that for the MPUIO IRQs, but the GPIO
> IRQs will come next.
More information about the linux-arm-kernel