[PATCH] ARM: kprobes: Fix error in conditional instruction checking

Nicolas Pitre nicolas.pitre at linaro.org
Thu Apr 21 14:27:01 EDT 2011

On Thu, 21 Apr 2011, Tixy wrote:

> From: Jon Medhurst <tixy at yxit.co.uk>
> The patch titled "ARM: kprobes: Fix probing of conditionally executed
> instructions" contains errors in the condition code checking functions
> __check_gt() and __check_lt(). These return the incorrect results if the
> Q flag is set because this is xored with the Z flag in the first
> expression. The fix is to use an intermediate temporary variable.
> Signed-off-by: Jon Medhurst <tixy at yxit.co.uk>

Good, I've folded this patch into the original commit where this bug was 
introduced, and pushed the amended branch.


More information about the linux-arm-kernel mailing list