[RFC PATCH 06/12] ARM: ux500: use remapped PPI interrupts for local timer

Marc Zyngier Marc.Zyngier at arm.com
Thu Apr 21 04:53:51 EDT 2011


On Thu, 2011-04-21 at 10:44 +0200, Srinidhi KASAGAR wrote:
> > -----Original Message-----
> > From: Marc Zyngier [mailto:marc.zyngier at arm.com]
> > Sent: Thursday, April 21, 2011 12:38 AM
> > To: LAK
> > Cc: Srinidhi KASAGAR; Linus WALLEIJ
> > Subject: [RFC PATCH 06/12] ARM: ux500: use remapped PPI interrupts for
> > local timer
> > 
> > Use the normal interrupt scheme for the local timers by using
> > a remapped PPI interrupt.
> > 
> > Cc: Srinidhi Kasagar <srinidhi.kasagar at stericsson.com>
> > Cc: Linus Walleij <linus.walleij at stericsson.com>
> > Signed-off-by: Marc Zyngier <marc.zyngier at arm.com>
> > ---
> >  arch/arm/mach-ux500/Kconfig      |    1 +
> >  arch/arm/mach-ux500/localtimer.c |    3 ++-
> >  2 files changed, 3 insertions(+), 1 deletions(-)
> > 
> > diff --git a/arch/arm/mach-ux500/Kconfig b/arch/arm/mach-ux500/Kconfig
> > index 5862601..6f3eb99 100644
> > --- a/arch/arm/mach-ux500/Kconfig
> > +++ b/arch/arm/mach-ux500/Kconfig
> > @@ -4,6 +4,7 @@ config UX500_SOC_COMMON
> >  	bool
> >  	default y
> >  	select ARM_GIC
> > +	select ARM_GIC_VPPI
> 
> Here you added VPPI and in the other patch 12/12 you remove this
> again and make it one time selectable based on CONFIG_SMP.
> is that done just for readability purpose?

This is in the interest of having a bisectable tree. Because I convert
each platform one at a time, I cannot immediately make CONFIG_SMP select
VPPI (that would break all the not-yet-converted platforms). Once all
platforms are using VPPI, patch #12 does the cleanup for configuration.

> Otherwise, for mach-ux500:
> Acked-by: Srinidhi Kasagar <srinidhi.kasagar at stericsson.com>

Thanks,

	M.
-- 
Reality is an implementation detail.





More information about the linux-arm-kernel mailing list