[PATCHv2 2.6.40 3/3] ARM:simpad: add GPIO based device definitions.
Jochen Friedrich
jochen at scram.de
Tue Apr 19 10:46:32 EDT 2011
Hi Dmitry,
>> arch/arm/mach-sa1100/Makefile | 1 -
>> arch/arm/mach-sa1100/leds-simpad.c | 97 ------------------------------------
>> arch/arm/mach-sa1100/simpad.c | 95 ++++++++++++++++++++++++++++++++++-
>> 3 files changed, 94 insertions(+), 99 deletions(-)
>> delete mode 100644 arch/arm/mach-sa1100/leds-simpad.c
>
> But, while removing leds-simpad.c, it seems you forgot to update both
> Makefile and corresponding entries in leds.[ch], so I suspect it will
> break build with CONFIG_LEDS=y.
Thanks for the review. I'll update my patch.
> And, while you're at it, it's probably a good idea to move all these LED
> changes into separate patch, and not to mix them with gpio-keys/i2c/etc
> devices registration.
I'll seperate the LED stuff from the rest of the patch.
Thanks,
Jochen
More information about the linux-arm-kernel
mailing list