genirq: Implement a generic interrupt chip

Thomas Gleixner tglx at linutronix.de
Mon Apr 18 15:43:31 EDT 2011



On Mon, 18 Apr 2011, Thomas Gleixner wrote:

> On Mon, 18 Apr 2011, H Hartley Sweeten wrote:
> > On Saturday, April 16, 2011 2:14 PM, Thomas Gleixner wrote:
> > > +void irq_setup_generic_chip(struct irq_chip_generic *gc, u32 msk,
> > > +			    unsigned int clr, unsigned int set)
> > > +{
> > > +	struct irq_chip_type *ct = gc->chip_types;
> > > +	unsigned int i;
> > > +
> > > +	/* Init mask cache */
> > > +	if (ct->irq_mask == irq_gc_mask_clr_bit ||
> > > +	    ct->irq_mask == irq_gc_mask_set_bit)
> > 
> > struct irq_chip_type does not have a member named 'irq_mask'
> 
> Found that already. Needs to be ct->chip_types->irq_mask of course.

Gah, my brain is seriously damaged from staring into that
code. ct->chip.irq_mask of course.
 
> Someday I hope that the patch to quilt which forces a refresh of the
> queue _BEFORE_ generating mail will surface :)
> 
> Thanks,
> 
> 	tglx
> 



More information about the linux-arm-kernel mailing list