[RFC 0/4] convert stmp into mxs and delete the obsolete platform

Arnd Bergmann arnd at arndb.de
Mon Apr 18 03:10:45 EDT 2011


On Monday 18 April 2011, Wolfram Sang wrote:
> From 25959b361a5d4af3138d70f5dfc8c357bee90170 Mon Sep 17 00:00:00 2001
> From: Wolfram Sang <w.sang at pengutronix.de>
> Date: Sun, 17 Apr 2011 19:49:28 +0200
> Subject: [RFC 1/4] arm: mach-mxs: add stmp378x-devb
> 
> STMP378x and MX23 are the same. There is a mach-stmp378x, however, it has a lot
> of reinvented interfaces, leaking all sorts of mach-specific functions into the
> drivers. One example is the dmaengine which does not use the linux
> dmaengine-API but some privately exported symbols. This makes generic use of
> the drivers impossible. mach-mxs does it better, so convert the board to
> mach-mxs. After that, it is possible to delete all stmp-specific code which
> should ease further ARM-consolidation.
> 
> Compile tested only due to no hardware (seems not available anymore).
> 
> Signed-off-by: Wolfram Sang <w.sang at pengutronix.de>

Ok, I guess there is not much that anyone can really complain about here.
What about the arch/arm/mach-stmp37xx/stmp37xx_devb.c file? You don't seem
to have a replacement for that machine.

Also, I noticed that the same series that added support for the platform
also added a few device drivers:
 * drivers/rtc/rtc-stmp3xxx.c
 * drivers/spi/spi_stmp.c
 * drivers/watchdog/stmp3xxx_wdt.c

Are these still used by the new code, and shared with the other i.MX23
code, or is there more duplication?

Finally, there are defconfig files:
 * arch/arm/configs/stmp378x_defconfig
 * arch/arm/configs/stmp37xx_defconfig

I would guess that these need to be updated.

	Arnd



More information about the linux-arm-kernel mailing list