[RFC] sanitizing crazy clock data files
u.kleine-koenig at pengutronix.de
Fri Apr 15 16:49:49 EDT 2011
On Fri, Apr 15, 2011 at 09:28:58PM +0100, Russell King - ARM Linux wrote:
> On Fri, Apr 15, 2011 at 09:25:35PM +0100, Russell King - ARM Linux wrote:
> > On Fri, Apr 15, 2011 at 10:12:32PM +0200, Sascha Hauer wrote:
> > > The other regular i.MXs should fit into this fine, they have the same
> > > patterns. mxs is different though, instead of enable bits they have
> > > disable bits and dividers are one based instead of zero. We can probably
> > > extend the patterns to handle some additional flags, but I haven't
> > > looked deeply into it.
> > A suggestion from work tglx is currently doing - name the two functions
> > which manipulate the mask bits 'set' and 'clear' rather than 'enable'
> > and 'disable'.
> > Then, the clk ops can do this:
> > .clk_enable = clk_gate_mask_set,
> > .clk_disable = clk_gate_mask_clear,
> > for ones with positive logic, and:
> > .clk_enable = clk_gate_mask_clear,
> > .clk_disable = clk_gate_mask_set,
> > for negative logic. No additional code required, just a variance in data
> > structure.
> Bah. Except they may need to reference the parent... which kills that
Then the actuall en/disabling needs to be a seperate callback.
clk_gate_enable(clk) then does
with sensiblename_enable pointing to clk_gate_mask_set or
Just my 2 cents before going to bed,
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | http://www.pengutronix.de/ |
More information about the linux-arm-kernel