[RFC PATCH] Consolidate SRAM support
Russell King - ARM Linux
linux at arm.linux.org.uk
Fri Apr 15 14:21:44 EDT 2011
On Fri, Apr 15, 2011 at 08:12:07PM +0200, Detlef Vollmann wrote:
>> Second point is that you'll notice that the code converts to a phys
>> address using this: phys = phys_base + (virt - virt_base). As soon as
>> we start allowing multiple regions of SRAM, it becomes impossible to
>> provide the phys address without a lot more complexity.
> Yes, I understand that. This either requires some intrusive changes
> to gen_pool code or quite some additional code in sram_pool_alloc.
It would require sram_pool to track each individual buffer alongside
the similar tracking that gen_pool does, and then look up the returned
address to find out which buffer it corresponds with.
As it looks though, this functionality isn't required on AT91. So lets
not complicate the code unless we know we have to. While the alloc/free
API is such that it'll be able to cope if we have to add it later - the
initialization will have to become a little more complex. And then I
start to wonder if gen_pool should just be extended for the phys address.
More information about the linux-arm-kernel