[RFC PATCH] Consolidate SRAM support
Russell King - ARM Linux
linux at arm.linux.org.uk
Fri Apr 15 11:24:43 EDT 2011
On Fri, Apr 15, 2011 at 04:52:38PM +0300, Eduardo Valentin wrote:
> Hi Russel,
> Just small comment,
> On Fri, Apr 15, 2011 at 08:06:07AM -0500, Russell King wrote:
> > diff --git a/arch/arm/plat-omap/sram.c b/arch/arm/plat-omap/sram.c
> > index a3f50b3..3588749 100644
> > --- a/arch/arm/plat-omap/sram.c
> > +++ b/arch/arm/plat-omap/sram.c
> > @@ -75,7 +75,6 @@
> > static unsigned long omap_sram_start;
> > static unsigned long omap_sram_base;
> > static unsigned long omap_sram_size;
> > -static unsigned long omap_sram_ceil;
> I think you missed one occurrence of omap_sram_ceil at omap3_sram_restore_context.
> Probably you have compile-tested w/o CONFIG_PM?
I built OMAP2 only, which did have CONFIG_PM=y. Welcome to the problems
of ifdef'ing code.
More information about the linux-arm-kernel