[PATCH v4 3/4] USB: Gadget: Add Samsung S3C24XX USB High-Speed controller driver

Alan Stern stern at rowland.harvard.edu
Thu Apr 14 11:35:43 EDT 2011


On Thu, 14 Apr 2011, Heiko [iso-8859-1] Stübner wrote:

> From: Thomas Abraham <thomas.ab at samsung.com>
> 
> The Samsung's S3C2416, S3C2443 and S3C2450 includes a USB High-Speed
> device controller module. This driver enables support for USB high-speed
> gadget functionality for the Samsung S3C24xx SoC's that include this
> controller.
> 
> Signed-off-by: Thomas Abraham <thomas.ab at samsung.com>
> Signed-off-by: Sangbeom Kim <sbkim73 at samsung.com>
> Signed-off-by: Kukjin Kim <kgene.kim at samsung.com>
> Signed-off-by: Alexander Neumann <alexander at bumpern.de>
> Signed-off-by: Heiko Stuebner <heiko at sntech.de>

...

> +static struct usb_ep_ops s3c_hsudc_ep_ops = {
> +	.enable = s3c_hsudc_ep_enable,
> +	.disable = s3c_hsudc_ep_disable,
> +	.alloc_request = s3c_hsudc_alloc_request,
> +	.free_request = s3c_hsudc_free_request,
> +	.queue = s3c_hsudc_queue,
> +	.dequeue = s3c_hsudc_dequeue,
> +	.set_halt = s3c_hsudc_set_halt,
> +};

There's no .set_wedge method.  Why do people always leave this out?

Alan Stern




More information about the linux-arm-kernel mailing list