[PATCH 4/6] ARM: mxc: don't allow to compile together i.MX51 and i.MX53

Russell King - ARM Linux linux at arm.linux.org.uk
Tue Apr 12 16:53:44 EDT 2011

On Tue, Apr 12, 2011 at 10:37:30PM +0200, Uwe Kleine-König wrote:
> > #if !defined(CONFIG_ARM_PATCH_PHYS_VIRT)
> > #if CONFIG_ARCH_MX1 + CONFIG_MACH_MX21 + ... > 1
> > #error Invalid configuration - unable to handle different phys base addresses
> > #endif
> Same problem (and I guess it yields some cpp warnings about
> CONFIG_ARCH_MX1 not being defined for an i.MX21-only build, but I didn't
> test).

Well then,

#if (CONFIG_ARCH_MX1 | CONFIG_MACH_MX21) + (...) + ... > 1

where each group of | cover those which share the same phys base.

No idea what those are because each MX SoC hides its phys base behind
some SoC private definition.  This is definitely a case where more
preprocessor junk reduces the code readability and makes it harder to
understand.  Removal of preprocessor indirection sounds like a candidate
for the consolidation effort to me.

I think we're at the point where "no" to that is not acceptable.  Make
it happen please.  We must reduce the size of arch/arm by all means

More information about the linux-arm-kernel mailing list