[RFC][PATCH V3] axi: add AXI bus driver

Greg KH greg at kroah.com
Mon Apr 11 17:25:13 EDT 2011

On Mon, Apr 11, 2011 at 11:19:13PM +0200, Rafał Miłecki wrote:
> 2011/4/11 Greg KH <greg at kroah.com>:
> > On Mon, Apr 11, 2011 at 11:25:14PM +0200, Rafał Miłecki wrote:
> >> +static void axi_release_core_dev(struct device *dev)
> >> +{
> >> +     /* Silent lack-of-release warning */
> >> +}
> >
> > Ok, WTF!!!!
> Thank you for your kindly words. It's much more enjoyable to work on
> kernel that way. I definitely made that on purpose.

I can't tell if you are kidding or not.

Please read the documentation for how to do this properly.  I find it
really hard to believe that you wrote that comment instead of putting in
the 2 lines of code required for this function.

Especially as-it-is, your code does not work properly and leaks memory
badly.  Why would you do that on purpose?


greg k-h

More information about the linux-arm-kernel mailing list