[RFC PATCH 0/5] Convert some ARM platforms to basic-mmio-gpio

Jamie Iles jamie at jamieiles.com
Mon Apr 11 11:21:10 EDT 2011


On Mon, Apr 11, 2011 at 05:17:53PM +0200, Linus Walleij wrote:
> 2011/4/11 Jamie Iles <jamie at jamieiles.com>:
> 
> > The basic-mmio-gpio driver has been extended in
> > <http://marc.info/?l=linux-kernel&m=130252092900804&w=2> to support a
> > larger wider of controllers and this series converts the ARM platforms
> > that do not implement I/O muxing in the GPIO driver or use the .to_irq
> > method of gpio_chip to use the driver.
> >
> > Jamie Iles (5):
> >  gemini: convert to basic-mmio-gpio
> >  sa1100: convert to basic-mmio-gpio
> >  w90x900: convert to basic-mmio-gpio
> >  iop: convert to basic-mmio-gpio
> >  mxc: convert to basic-mmio-gpio
> 
> For all of these, maybe you can
>   select GPIO_BASIC_GPIO
> 
> In their mach-xxx/Kconfig so that the driver gets compiled-in by default?

OK, Uwe has suggested that already so I'll fix that up for the next 
attempt.

> Further the basic_mmio_gpio.c driver looks a bit dangerous: it only uses
> __raw_* accessors for the GPIO registers, I'd very much like to replace that
> with the non-__raw* versions if this is to have any generic impact.
> 
> The raw accessors can get stuck in things like write buffers and the like
> IIRC, they usually won't so you don't notice first, then you start getting
> all kind of real strange bugs.

Sounds sensible.  I'll create a patch to convert to use the non raw 
versions then.

Jamie



More information about the linux-arm-kernel mailing list