[PATCH v2] leds: provide helper to register "leds-gpio" devices
rpurdie at rpsys.net
Wed Apr 6 07:52:18 EDT 2011
On Tue, 2011-04-05 at 22:24 +0200, Uwe Kleine-König wrote:
> This function makes a deep copy of the platform data to allow it to live
> in init memory.
> The definition cannot go into leds-gpio.c because it needs to be builtin
> to be usable by platforms.
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig at pengutronix.de>
> changes since v1:
> - don't add __init to the declaration of gpio_led_register_device
> drivers/leds/led-core.c | 27 ++++++++++++++++++++++++++-
> include/linux/leds.h | 12 ++++++++++++
> 2 files changed, 38 insertions(+), 1 deletions(-)
Can you explain the reasoning for this a little further please? It
sounds like instead of leaving the platform data in memory (which is
reasonable since we need it), we're now adding code to make a copy of
this data so we can remove the original. Why?
I have a rather strong dislike of adding "always builtin" functions as
they suggest something is wrong with the approach. led-core.c has always
been intentionally as minimal as we could get it.
In times when things like boot time are important it also seems like bad
form to be copying data around just so we can throw one copy away during
the boot process. What memory savings (which I assume is the
motivation?) is this giving us at what cost?
I guess the motivation might be that if a given platform has many
different LED configurations, you're trying to remove the ones you don't
need from memory? Given all the above I'd suggest that this function
should really be added to the platform device code if anywhere and
doesn't belong in the LED subsystem as its not an LED specific problem.
More information about the linux-arm-kernel