[PATCH] leds: provide helper to register "leds-gpio" devices

[H Hartley Sweeten]

On Tuesday, April 05, 2011 9:29 AM, Fabio Estevam wrote:
> On 4/5/2011 1:13 PM, Fabio Estevam wrote:
>> Hi Uwe,
>> 
>> On 4/5/2011 5:37 AM, Uwe Kleine-König wrote:
>>> This function makes a deep copy of the platform data to allow it to live
>>> in init memory.
>>> The definition cannot go into leds-gpio.c because it needs to be builtin
>>> to be usable by platforms.
>>>
>>> Signed-off-by: Uwe Kleine-König <u.kleine-koenig at pengutronix.de>
>> 
>> I tested your patch on a MX53EVK board, but I could only build it after unselecting the mmc driver.
>> 
>> This is the error I got when mmc was selected:
>> 
>>   CC      drivers/mmc/card/mmc_test.o
>>   LD      drivers/mmc/card/built-in.o
>>   CC      drivers/mmc/core/sdio_io.o
>> In file included from include/linux/mmc/host.h:13,
>>                  from drivers/mmc/core/sdio_io.c:12:
>> include/linux/leds.h:220: error: expected '=', ',', ';', 'asm' or '__attribute__' before 'gpio_led_register_device'
>> make[3]: *** [drivers/mmc/core/sdio_io.o] Error 1
>> make[2]: *** [drivers/mmc/core] Error 2
>> make[1]: *** [drivers/mmc] Error 2
>> make: *** [drivers] Error 2
>
> If I declare it as "platform_device *gpio_led_register_device" then it builds fine.

With the change Fabio pointed out this builds and works fine on the ep93xx.

Hartley