[PATCH v3 2/2] ARM: ptrace: Migrate to regsets framework

Dave Martin dave.martin at linaro.org
Tue Apr 5 05:07:38 EDT 2011


On Mon, Apr 4, 2011 at 7:51 PM, Ulrich Weigand
<Ulrich.Weigand at de.ibm.com> wrote:
> Dave Martin <dave.martin at linaro.org> wrote on 04/04/2011 06:43:26 PM:
>
>> +/*
>> + * The size of the user-visible VFP state as seen by
> PTRACE_GET/SETVFPREGS
>> + * and core dumps.
>> + */
>> +#define ARM_VFPREGS_SIZE ( 32 * 4 /*fpregs*/ + 4 /*fpscr*/ )
>
> This should be 32 * 8 + 4, not 32 * 4 + 4, shouldn't it?

Umm, yeah -- dumb mistake

I've reposted with this fixed.

Ideally, I'd have liked to defined that in terms of struct user_vfp,
but that results in a cascade of header dependencies I prefer to
avoid.  Also, since this definition is describing a binary protocol,
using the type definition to define it could be undesirable.

Cheers
---Dave



More information about the linux-arm-kernel mailing list