[PATCH v2 1/2] ARM: mxc: Introduce imx_add_gpio_leds

Tue Apr 5 04:32:59 EDT 2011

On Tue, Apr 05, 2011 at 08:59:32AM +0100, Russell King - ARM Linux wrote:
> On Tue, Apr 05, 2011 at 09:51:18AM +0200, Uwe Kleine-König wrote:
> > This was intended by
> > 
> > 	struct gpio_led_platform_data *_pdata = *pdata;
> > 
> > I'm just fighting with the compiler at this line because it doesn't like
> > _pdata being initialized by a const pointer.
> 
> That's idiotic and revolting.  Casting away const means you're writing
> broken code, which can fail for XIP users.  If you're going to play
> such games, there's *NO* point in marking it const in the first place.
No I won the fight with the compiler, the result is

	struct gpio_led_platform_data _pdata = *pdata

which AFAIK is valid C and even works for XIP users.

Best regards
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |