[PATCH] video: mxsfb: correct typo 'FAILING' to 'FALLING'
Uwe Kleine-König
u.kleine-koenig at pengutronix.de
Tue Apr 5 03:36:24 EDT 2011
On Tue, Apr 05, 2011 at 02:47:55PM +0800, Shawn Guo wrote:
> Signed-off-by: Shawn Guo <shawn.guo at freescale.com>
> ---
> The patch should probably be split into two to separate machine code
> changes from driver ones, but that will result in build failure,
> which could be a problem for bisect, so I keep them as one patch.
to prevent that (and if you really care) you need to add a
#define FB_SYNC_DOTCLK_FAILING_ACT FB_SYNC_DOTCLK_FALLING_ACT
in the first patch, then fix all users and then remove the #define
again. But IMHO it's totally OK to do it in one step since all files
touched are in a single maintainer's responsibility.
(At least drivers/video/mxsfb.c went in via Sascha's tree, too.)
Reported-by: Uwe Kleine-König <u.kleine-koenig at pengutronix.de>
Acked-by: Uwe Kleine-König <u.kleine-koenig at pengutronix.de>
Best regards
Uwe
> arch/arm/mach-mxs/include/mach/mxsfb.h | 2 +-
> arch/arm/mach-mxs/mach-mx23evk.c | 2 +-
> arch/arm/mach-mxs/mach-mx28evk.c | 2 +-
> drivers/video/mxsfb.c | 6 +++---
> 4 files changed, 6 insertions(+), 6 deletions(-)
--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | http://www.pengutronix.de/ |
More information about the linux-arm-kernel
mailing list