[PATCH] plat-mxc: Provide irq_chip name for GPIO IRQs

Alexander Stein alexander.stein at systec-electronic.com
Mon Apr 4 11:21:21 EDT 2011


On Monday 04 April 2011, 16:34:08 Russell King - ARM Linux wrote:
> On Mon, Apr 04, 2011 at 04:29:36PM +0200, Uwe Kleine-König wrote:
> > On Tue, Mar 01, 2011 at 09:34:15AM +0100, Wolfram Sang wrote:
> > > Hi,
> > > 
> > > > >  static struct irq_chip gpio_irq_chip = {
> > > > > 
> > > > > +	.name = "GPIO",
> > > 
> > > I'd suggest a more specific name, e.g. "i.MX GPIO"? You can then also
> > > add my
> > > 
> > > Acked-by: Wolfram Sang <w.sang at pengutronix.de>
> > 
> > This comment wasn't addressed. Does someone care to follow up?
> 
> And if we consolidate the GPIO implementations (I hope *someone* is
> working on that) then this doesn't matter one ounce because platforms
> won't be identifying that its an 'i.MX GPIO'.

The benefit from this patch is that it gets shown at /proc/interrupts. But I 
personally don't care if it's "GPIO" as in mainline now or "i.MX GPIO"

Alexander



More information about the linux-arm-kernel mailing list