[PATCH 2/3] Use gpio_set_value_cansleep() in corgi_lcd.c

Marek Vasut marek.vasut.n900 at gmail.com
Mon Apr 4 08:52:53 EDT 2011


> On Mon, Apr 04, 2011 at 02:44:17PM +0200, Marek Vasut wrote:
> > > On Mon, Apr 4, 2011 at 8:06 PM, Mark Brown
> > > <broonie at opensource.wolfsonmicro.com> wrote:
> > > > On Mon, Apr 04, 2011 at 06:45:46PM +0800, Eric Miao wrote:
> > > > > Personally, I don't quite like the idea of an explicit
> > > > > _cansleep() version, which is just confusing. A programmer
> > > > > shouldn't be aware of which version to use.
> > > > 
> > > > When working in interrupt context you need to pay attention to this
> > > > stuff; personally I'd prefer an explict IRQ safe version but YMMV.
> > > >  The only use the code makes of this is to generate warnings to
> > > > make problems easier to diagnose.
> > > > 
> > > > > David, you have any justification?
> > > > 
> > > > Sadly David passed away recently.
> > > > 
> > > 
> > > What????!!!!????? I didn't know that.
> > 
> > Me neither. I'm shocked. What happened?
> 
> From what I can tell, so far it's been passed around in private mail
> only, and so people are hearing about it 3rd, 4th or more hand - which
> really isn't the way to go about giving this news.
> 
> So, I'm not going to pass on the details which I've heard, instead
> I'd suggest people wait for (or try to find) an official announcement.
> 

My condolences :-(




More information about the linux-arm-kernel mailing list