[PATCH 2/3] Use gpio_set_value_cansleep() in corgi_lcd.c

Marek Vasut marek.vasut.n900 at gmail.com
Mon Apr 4 08:44:17 EDT 2011


> On Mon, Apr 4, 2011 at 8:06 PM, Mark Brown
> <broonie at opensource.wolfsonmicro.com> wrote:
> > On Mon, Apr 04, 2011 at 06:45:46PM +0800, Eric Miao wrote:
> > > Personally, I don't quite like the idea of an explicit _cansleep()
> > > version, which is just confusing. A programmer shouldn't be aware of
> > > which version to use.
> > 
> > When working in interrupt context you need to pay attention to this
> > stuff; personally I'd prefer an explict IRQ safe version but YMMV.  The
> > only use the code makes of this is to generate warnings to make
> > problems easier to diagnose.
> > 
> > > David, you have any justification?
> > 
> > Sadly David passed away recently.
> > 
> 
> What????!!!!????? I didn't know that.

Me neither. I'm shocked. What happened?




More information about the linux-arm-kernel mailing list