RFC, GIC based smp_cross_call cleanup suggestion

[Santosh Shilimkar]

On 4/3/2011 5:16 PM, Russell King - ARM Linux wrote:
> On Sun, Apr 03, 2011 at 04:23:41PM +0530, Santosh Shilimkar wrote:
>> Sure, it does break OMAP4. These functions are there because they
>> are used/compiled only for SMP support.
>
> If they're only used privately within the mach-omap2 code, then putting
> them in a header file in arch/arm/mach-omap2 would've been the logical
> thing to do, rather than telling the entire SMP kernel about the
> functions.
>
Ok. Make sense.

> Header files in arch/arm/*/include/mach included from
> arch/arm/include/asm/*.h are there to provide necessary definitions for
> either the rest of the kernel or the ARM specific parts.  They shouldn't
> be polluted with *any* platform private stuff which is not absolutely
> necessary to satisfy the rest of the kernel.  Those mach/ includes
> being:
>
> mach/barriers.h
> mach/clkdev.h
> mach/floppy.h
> mach/gpio.h
> mach/hardware.h
> mach/io.h
> mach/irqs.h
> mach/isa-dma.h
> mach/memory.h
> mach/mtd-xip.h
> mach/smp.h
> mach/timex.h
> mach/vmalloc.h
>
Thanks for the list. I shall move those to omap4-common.h
I didn't do it last time thinking file
"arch/arm/plat-omap/include/plat/smp.h" can have platform
specific functions as well.

I missed the point that "mach/smp.h" would be included
indirectly by "linux/smp.h"

Thanks for making this clear to me.

Regards
Santosh