[PATCH] arm: nomadik: avoid assigning u32 to bool
Linus Walleij
linus.walleij at linaro.org
Sat Apr 2 17:02:49 EDT 2011
2011/4/1 Nicolas Kaiser <nikai at nikai.net>:
> Avoid assigning u32 to the bool 'enabled'.
>
> Signed-off-by: Nicolas Kaiser <nikai at nikai.net>
> ---
> arch/arm/plat-nomadik/gpio.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/arch/arm/plat-nomadik/gpio.c b/arch/arm/plat-nomadik/gpio.c
> index f49748e..8b722f7 100644
> --- a/arch/arm/plat-nomadik/gpio.c
> +++ b/arch/arm/plat-nomadik/gpio.c
> @@ -636,7 +636,7 @@ static int nmk_gpio_irq_set_type(struct irq_data *d, unsigned int type)
> if (type & IRQ_TYPE_LEVEL_LOW)
> return -EINVAL;
>
> - enabled = nmk_chip->enabled & bitmask;
> + enabled = !!(nmk_chip->enabled & bitmask);
I've learned to live this way of casting stuff into boolean,
Acked-by: Linus Walleij <linus.walleij at linaro.org>
Linus Walleij
More information about the linux-arm-kernel
mailing list