[PATCH 2/9] ARM: pxa: enable sparsemem in saarb

[Eric Miao]

On Sat, Apr 2, 2011 at 2:33 AM, Russell King - ARM Linux
<linux at arm.linux.org.uk> wrote:
> On Fri, Apr 01, 2011 at 01:10:52PM +0800, Eric Miao wrote:
>> On Fri, Apr 1, 2011 at 12:35 PM, Haojian Zhuang <hzhuang1 at marvell.com> wrote:
>> > If I use HIGHMEM now, our some drivers and apps should be changed also. We don't want to change them.
>>
>> I don't understand this will cause side effects to other drivers and apps?
>
> If they're not using kmap_atomic() but are dealing directly with
> page addresses, they'll fail if the pages are coming from highmem.
>
> Given Linus' complaints in the OMAP pull request thread, I think we
> should refuse, and have the drivers fixed to work with highmem.
>

That's what I thought as well.

Haojian,

Please work on enabling highmem, anything that's going to prevent
us from having a single kernel binary, will just make the situation
worse. Thanks