[PATCH 1/2] Fixing ethernet driver compilation error for i.MX31 ADS board
Uwe Kleine-König
u.kleine-koenig at pengutronix.de
Thu Sep 30 14:14:33 EDT 2010
Hello,
On Thu, Sep 30, 2010 at 04:47:34PM +0100, Ian Lartey wrote:
> This is only a partial revert of "ARM: mx3/mx31ads: fold board header in
> its only user" [commit ccfa7c269843001077df02d98918c6c9bde91395)]
>
> As some of the the board defines are also used in the cs89x0 ethernet
> driver by the i.MX31 ADS.
>
> Signed-off-by: Ian Lartey <ian at opensource.wolfsonmicro.com>
It seems you got me wrong. I wanted you to just define the constants in
arch/arm/plat-mxc/include/mach/board-mx31ads.h that are needed by the
cs89x0 driver. That is PBC_BASE_ADDRESS, PBC_CS8900A_IOBASE and
EXPIO_INT_ENET_INT. And I wanted a comment like:
/*
* These symbols are used by drivers/net/cs89x0.c.
* This is ugly as hell, but we have to provide them until
* someone fixed the driver.
*/
And you definitly shouldn't reintroduce these doxygen comments.
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | http://www.pengutronix.de/ |
More information about the linux-arm-kernel
mailing list