[PATCH] OMAP2PLUS: WDT: Fix: Disable WDT after reset during init

Paul Walmsley paul at pwsan.com
Thu Sep 30 12:43:05 EDT 2010


Hello Charu,

On Thu, 30 Sep 2010, Varadarajan, Charulatha wrote:

> > > diff --git a/arch/arm/mach-omap2/devices.c b/arch/arm/mach-omap2/devices.c
> > > index 8e2f0aa..9f44fc6 100644
> > > --- a/arch/arm/mach-omap2/devices.c
> > > +++ b/arch/arm/mach-omap2/devices.c
> > > +
> > > +static void __init omap_disable_wdt(void)
> > > +{
> > > +	if (cpu_class_is_omap2())
> > 
> > This code is already in mach-omap2/devices.c, so that test should be 
> > useless.
> 
> I do not see a cpu_class_is_omap2() check in omap2_init_devices(). Please
> point out where this check is done while/before calling omap_disable_wdt()?

It's implicit, due to the directory arch/arm/mach-omap2/ -- code in that 
directory is only built for OMAP2+ systems -- and right now there are no 
plans for OMAP1+ multi-arch booting.  So it's safe to assume that any code 
in arch/arm/mach-omap2 will only run on OMAP2+ boards.


- Paul



More information about the linux-arm-kernel mailing list