[PATCH] ARM: Samsung S5P: Unify defines for both gpio interrupt types

Kukjin Kim kgene.kim at samsung.com
Thu Sep 30 07:45:36 EDT 2010


Marek Szyprowski wrote:
> 
> Hello,
> 
Hi,

(snip)

> >
> > Ok..firstly looks ok to me now.
> > But I don't know...in the future may have to revert back due to S5P64XX.
> 
> Well, these defines are used only by plat-s5p/irq-{eint,gpioint}.c. These
generic
> functions cannot be used for S5P64XX anyway, because it has S3C64XX style
of
> gpio
> registers afair. IMHO this shouldn't be a problem. Just S5P64XX would need
to
> provide it's own code for gpio/ext interrupts (or share the code with
s3c64xx
> somehow).
> 
Yes, you're right. It seems to have been useless worry.
However, it is likely to think of once again later.

Thanks.

Best regards,
Kgene.
--
Kukjin Kim <kgene.kim at samsung.com>, Senior Engineer,
SW Solution Development Team, Samsung Electronics Co., Ltd.




More information about the linux-arm-kernel mailing list