[PATCH 1/7] SPI: add PrimeCell generic DMA to PL022 v12
Linus Walleij
linus.walleij at stericsson.com
Wed Sep 29 07:54:11 EDT 2010
Grant Likely wrote:
> On Tue, Sep 28, 2010 at 04:33:55PM +0200, Linus Walleij wrote:
>> This extends the PL022 SSP/SPI driver with generic DMA engine
>> support using the PrimeCell DMA engine interface. Also fix up the
>> test code for the U300 platform.
>> (...)
>> --- a/arch/arm/mach-u300/dummyspichip.c
>> +++ b/arch/arm/mach-u300/dummyspichip.c
>> @@ -267,6 +267,7 @@ static struct spi_driver pl022_dummy_driver = {
>> .driver = {
>> .name = "spi-dummy",
>> .owner = THIS_MODULE,
>> + .bus = &spi_bus_type,
>
> This shouldn't be necessary. spi_register_driver already sets the bus
> type field.
>
> Otherwise, this patch looks good. If you're okay with me dropping
> this hunk, then I'll pick up this patch into my next-spi branch.
OK just drop it, thanks Grant.
I need to come up with the right way to refactor that dummychip anyway
to I'll churn it out completely sooner or later.
Yours,
Linus Walleij
More information about the linux-arm-kernel
mailing list