[PATCH v2 08/10] TWL IRQ: Fix fucntion declaration warnings

[G, Manjunath Kondaiah]

> -----Original Message-----
> From: linux-omap-owner at vger.kernel.org 
> [mailto:linux-omap-owner at vger.kernel.org] On Behalf Of G, 
> Manjunath Kondaiah
> Sent: Monday, September 27, 2010 6:40 PM
> To: Samuel Ortiz
> Cc: linux-omap at vger.kernel.org; 
> linux-arm-kernel at lists.infradead.org; Tony Lindgren; Menon, Nishanth
> Subject: RE: [PATCH v2 08/10] TWL IRQ: Fix fucntion 
> declaration warnings
> 
> 
> Hi Samuel,
> 
> > -----Original Message-----
> > From: Samuel Ortiz [mailto:sameo at linux.intel.com]
> > Sent: Monday, September 27, 2010 4:46 PM
> > To: G, Manjunath Kondaiah
> > Cc: linux-omap at vger.kernel.org;
> > linux-arm-kernel at lists.infradead.org; Tony Lindgren; Menon, Nishanth
> > Subject: Re: [PATCH v2 08/10] TWL IRQ: Fix fucntion declaration 
> > warnings
> > 
> > Hi Manjunath,
> > 
> > On Tue, Sep 21, 2010 at 03:31:18PM +0530, G, Manjunath 
> Kondaiah wrote:
> > > Fixes following sparse warnings for twl4030 and twl6030 irq files.
> > > 
> > > drivers/mfd/twl4030-irq.c:783:5: warning: symbol
> > 'twl4030_init_irq' was not declared. Should it be static?
> > > drivers/mfd/twl4030-irq.c:863:5: warning: symbol
> > 'twl4030_exit_irq' was not declared. Should it be static?
> > > drivers/mfd/twl4030-irq.c:873:5: warning: symbol
> > 'twl4030_init_chip_irq' was not declared. Should it be static?
> > > 
> > > drivers/mfd/twl6030-irq.c:226:5: warning: symbol
> > 'twl6030_init_irq' was not declared. Should it be static?
> > > drivers/mfd/twl6030-irq.c:290:5: warning: symbol
> > 'twl6030_exit_irq' was not declared. Should it be static?
> > > 
> > > Signed-off-by: G, Manjunath Kondaiah <manjugk at ti.com>
> > > Cc: linux-arm-kernel at lists.infradead.org
> > > Cc: Samuel Ortiz <sameo at linux.intel.com>
> > > Cc: Tony Lindgren <tony at atomide.com>
> > > Cc: Nishanth Menon <nm at ti.com>
> > > ---
> > >  include/linux/i2c/twl.h |    5 +++++
> > >  1 files changed, 5 insertions(+), 0 deletions(-)
> > > 
> > > diff --git a/include/linux/i2c/twl.h
> > b/include/linux/i2c/twl.h index
> > > 6de90bf..c61e90a 100644
> > > --- a/include/linux/i2c/twl.h
> > > +++ b/include/linux/i2c/twl.h
> > > @@ -172,6 +172,11 @@ int twl_i2c_read(u8 mod_no, u8 
> *value, u8 reg, 
> > > unsigned num_bytes);
> > >  
> > >  int twl6030_interrupt_unmask(u8 bit_mask, u8 offset);  int
> > > twl6030_interrupt_mask(u8 bit_mask, u8 offset);
> > > +int twl6030_init_irq(int irq_num, unsigned irq_base, unsigned 
> > > +irq_end); int twl6030_exit_irq(void); int twl4030_init_irq(int 
> > > +irq_num, unsigned irq_base, unsigned irq_end); int 
> > > +twl4030_exit_irq(void); int twl4030_init_chip_irq(const
> > char *chip);
> > No, we don't want to export those. Try defining them as extern from 
> > twl*-irq.c.
> 
> Having extern in .c file will generate checkpatch warning as:
> WARNING: externs should be avoided in .c files

As an alternate, how about having twl-core.h in drivers/mfd and defining them
as extern so that these API's will be available only to files under drivers/mfd?

-Manjunath