[GIT PULL] omap2 sparse fixes

[G, Manjunath Kondaiah]

Hi Tony, 

> -----Original Message-----
> From: Tony Lindgren [mailto:tony at atomide.com] 
> Sent: Saturday, September 25, 2010 5:49 AM
> To: G, Manjunath Kondaiah
> Cc: linux-omap at vger.kernel.org; linux-arm-kernel at lists.infradead.org
> Subject: Re: [GIT PULL] omap2 sparse fixes
> 
> * G, Manjunath Kondaiah <manjugk at ti.com> [100924 12:33]:
> > 
> > Tony,
> > Here is new pull request which is rebased to 2.6.36-rc5.
> > 
> > -Manjunath
> > 
> > The following changes since commit 
> b30a3f6257ed2105259b404d419b4964e363928c:
> >   Linus Torvalds (1):
> >         Linux 2.6.36-rc5
> > 
> > are available in the git repository at:
> > 
> >   git://dev.omapzoom.org/pub/scm/manju/kernel-omap3-dev.git 
> > sparse_fixes
> > 
> > G, Manjunath Kondaiah (10):
> >       OMAP: mach-omap2: Fix incorrect assignment warnings
> >       OMAP: mach-omap2: Fix static declaration warnings
> >       OMAP: mach-omap2: Fix static function warnings
> >       OMAP: mach-omap2: Fix miscellaneous sparse warnings
> >       OMAP: plat-omap: Fix static function warnings
> >       OMAP: NAND: Fix static declaration warning
> >       TWL CORE: Fix sparse warning
> >       TWL IRQ: Fix fucntion declaration warnings
> >       OMAP2/3: Convert write/read functions to raw read/write
> >       OMAP3: Keypad: Fix incorrect type initializer
> 
> Hmm tried pulling these, but ran into an issue where at least 
> 2430 takes about a minute to boot with these patches with no 
> output on the console intially.

Here is test report for all the boards:

1. omap3_defconfig with 2.6.36-rc5 code as is does not seems to be
boot. Enabled early printk and found it was due to musb driver. 
Boot log is here:
2430sdp_omap3_defconfig_bootlog_nochanges2code.txt
http://pastebin.com/wd92PMmE


2. Disabled musb in omap3_defconfig and boot seems be fine.
2430sdp_omap3_defconfig_bootlog_usbdisable
http://pastebin.com/eExED5q4


3. With sparse fix series, booting is as expected with omap3_defconfig
2430sdp_omap3_defconfig_bootlog_usbdisable_sparse_fixes.txt
http://pastebin.com/GMX4y2fS


4. Here zoom3 boot log:
Zoom3_omap3_defconfig_bootlog_usbdisable_sparse_fixes.
http://pastebin.com/C2A6YXAL


5. omap4 sdp boot log(with es2.0 patches pulled from for-next branch)
omap4sdp_es2.0_omap3_defconfig_bootlog_sparse_fixes.
http://pastebin.com/ebiP1X2h


> 
> Can you please check that? Will not merge for now until we 
> figure out what changes with these patches.
> 
> Then, I also noticed the following exports getting added:
> 
> +EXPORT_SYMBOL(omap2_gp_clockevent_set_gptimer);
> +EXPORT_SYMBOL(omapfb_reserve_sram);
> +EXPORT_SYMBOL(omap_sram_init);
> 
> These should not be exported, they are only intended to be 
> called from the low-level platform init code. So exporting 
> them is not the right fix for these.

I have declared these API's as extern functions in respective
header files. If it is ok, I can push the changes to git branch
for pull request.

-Manjunath