[PATCH 1/4] mmc: sdhci-pltfm: Add structure for host-specific data

[Anton Vorontsov]

Hello,

On Sun, Sep 26, 2010 at 05:02:29AM -0400, zhangfei gao wrote:
> On Tue, Sep 21, 2010 at 8:30 AM, Wolfram Sang <w.sang at pengutronix.de> wrote:
> > +++ b/drivers/mmc/host/sdhci-pltfm.h
> > @@ -13,6 +13,11 @@
> >
> >  #include <linux/sdhci-pltfm.h>
> >
> > +struct sdhci_pltfm_host {
> > +       struct clk *clk;
> > +       u32 scratchpad; /* to handle quirks across io-accessor calls */
> > +};
> > +
> How about move private data to child driver, and one call back
> function alloc_host, then child driver could alloc private data,
> including clk.

IMHO, this sounds like a bit of overdesign/overcomplication.

-- 
Anton Vorontsov
email: cbouatmailru at gmail.com
irc://irc.freenode.net/bd2