[PATCH v7 4/6] OMAP4: hwmod data: Add watchdog timer

Kevin Hilman khilman at deeprootsystems.com
Fri Sep 24 15:07:19 EDT 2010


"Cousson, Benoit" <b-cousson at ti.com> writes:

> On 9/21/2010 3:37 PM, Varadarajan, Charulatha wrote:

[...]

>>   static __initdata struct omap_hwmod *omap44xx_hwmods[] = {
>>   	/* dmm class */
>>   	&omap44xx_dmm_hwmod,
>> @@ -472,6 +602,11 @@ static __initdata struct omap_hwmod *omap44xx_hwmods[] = {
>>
>>   	/* mpu class */
>>   	&omap44xx_mpu_hwmod,
>> +	/* wd_timer class */
>> +	&omap44xx_wd_timer2_hwmod,
>> +
>> +	/* wd_timer3 not yet supported */
>> +/*	&omap44xx_wd_timer3_hwmod, */
>
> Sorry, I forgot to comment that part in your previous revision.
> What we agreed with Kevin is to enable that hwmod watchdog as well in
> order to allow the hwmod core to initialize properly this module, even
> if it not used by any driver yet.
>
> Beside that you can add my Acked-by: for the whole series.

Charu,

If this is OK with you, can you test with timer3 hwmod enabled, and
repost an updated version of this patch?

Then, I will add Benoit's ack and queue this up for 2.6.37.

Kevin




More information about the linux-arm-kernel mailing list