[PATCH 0/3] [ARM] tegra: PCI Express support

Arnd Bergmann arnd at arndb.de
Mon Sep 20 05:13:34 EDT 2010


On Monday 20 September 2010, Mike Rapoport wrote:
> static struct resource pcie_res[] = {
>         [0] = {
>                 .name   = "PCIe IO",
>                 .start  = 0x1000,
>                 .end    = 0x1000 + IO_SIZE - 1,
>                 .flags  = IORESOURCE_IO,
>         },

The end should be 'IO_SIZE - 1' or IO_SPACE_LIMIT (should be the same anyway),
not '0x1000 + IO_SIZE - 1'. The reason for the 0x1000 is that the first 4096
ports are reserved for legacy ISA devices by setting PCIBIOS_MIN_IO.

The rest looks fine AFAICT.

	Arnd



More information about the linux-arm-kernel mailing list