[PATCH 11/14] omap4: Fix silicon version detection for early samples

Shilimkar, Santosh santosh.shilimkar at ti.com
Fri Sep 17 06:23:52 EDT 2010


> -----Original Message-----
> From: Menon, Nishanth
> Sent: Friday, September 17, 2010 3:48 PM
> To: Shilimkar, Santosh; linux-omap at vger.kernel.org
> Cc: linux-arm-kernel at lists.infradead.org
> Subject: RE: [PATCH 11/14] omap4: Fix silicon version detection for early
> samples
> 
> > -----Original Message-----
> > From: linux-omap-owner at vger.kernel.org [mailto:linux-omap-
> > owner at vger.kernel.org] On Behalf Of Shilimkar, Santosh
> > Sent: Friday, September 17, 2010 4:48 AM
> 
> [..]
> 
> > diff --git a/arch/arm/mach-omap2/id.c b/arch/arm/mach-omap2/id.c
> > index ae70ae9..0412233 100644
> > --- a/arch/arm/mach-omap2/id.c
> > +++ b/arch/arm/mach-omap2/id.c
> > @@ -308,6 +308,15 @@ static void __init omap4_check_revision(void)
> >  	hawkeye = (idcode >> 12) & 0xffff;
> >  	rev = (idcode >> 28) & 0xff;
> >
> > +	/*
> > +	 * Few initial ES2.0 samples IDCODE is same as ES1.0
> > +	 * Use ARM register to detect the correct ES version
> > +	 */
> > +	if (!rev) {
> > +		idcode = read_cpuid(CPUID_ID);
> > +		rev = (idcode & 0xf) - 1;
> > +	}
> > +
> 
> Squash this to patch 10?
> 
Actually this was kind of temporary patch and was suppose to be
reverted later and hence I kept it separate. 
Felipe, benoit suggested to have this change anyways considering
it's just one check.
http://www.mail-archive.com/linux-omap@vger.kernel.org/msg34521.html

But now I think we can fold this into id patch itself. Will fold it
into patch 10.

Regards,
Santosh





More information about the linux-arm-kernel mailing list