[PATCH 05/14] omap4: control: Add accessor api's for pad control module

Menon, Nishanth nm at ti.com
Fri Sep 17 06:17:18 EDT 2010


> -----Original Message-----
> From: linux-omap-owner at vger.kernel.org [mailto:linux-omap-
> owner at vger.kernel.org] On Behalf Of Santosh Shilimkar
> Sent: Friday, September 17, 2010 4:48 AM
> 
> On OMAP4 control pad are not addressable from control
> core base. So the common omap_ctrl_read/write APIs breaks
> Hence export separate APIs to manage the omap4 pad control
> registers.
> 
> This APIs will work only for OMAP4

Cosmetic comment below:

> 
> Signed-off-by: Santosh Shilimkar <santosh.shilimkar at ti.com>
> ---
>  arch/arm/mach-omap2/control.c             |   18 ++++++++++++++++++
>  arch/arm/plat-omap/include/plat/control.h |    4 ++++
>  2 files changed, 22 insertions(+), 0 deletions(-)
> 
> diff --git a/arch/arm/mach-omap2/control.c b/arch/arm/mach-omap2/control.c
> index 99c0eb6..4ace2d1 100644
> --- a/arch/arm/mach-omap2/control.c
> +++ b/arch/arm/mach-omap2/control.c
> @@ -138,6 +138,7 @@ static struct omap3_control_regs control_context;
>  #endif /* CONFIG_ARCH_OMAP3 && CONFIG_PM */
> 
>  #define OMAP_CTRL_REGADDR(reg)		(omap2_ctrl_base + (reg))
> +#define OMAP_CTRL_PAD_REGADDR(reg)	(omap4_ctrl_pad_base + (reg))
s/ OMAP_CTRL_PAD_REGADDR/OMAP4_CTRL_PAD_REGADDR ?
[...]


Regards,
Nishanth Menon




More information about the linux-arm-kernel mailing list