[PATCH v5 3/7] wireless: wl12xx: add platform data passing support
Ohad Ben-Cohen
ohad at wizery.com
Wed Sep 15 04:00:22 EDT 2010
2010/9/6 Michał Mirosław <mirqus at gmail.com>:
> W dniu 6 września 2010 14:07 użytkownik Russell King - ARM Linux
> <linux at arm.linux.org.uk> napisał:
>> On Sat, Sep 04, 2010 at 02:23:19PM +0200, Michał Mirosław wrote:
>>> 2010/9/1 Ohad Ben-Cohen <ohad at wizery.com>:
>>> > Add a simple mechanism to pass platform data to the
>>> > SDIO instances of wl12xx.
> [cut patch]
>>> Why do you need all that copying? Isn't the data constant?
>>
>> The first copy is to allow platforms to have their data marked with
>> __initdata. The second copy probably isn't necessary, but avoids
>> problems where the driver may decide to modify the platform data.
>
> Sorry for pushing at this, but why would you mark data that's meant to
> be used after init phase as __initdata?
I can remove the first copying as well if Russell is ok with it.
Both ways work for us.
>
> Best Regards,
> Michał Mirosław
>
More information about the linux-arm-kernel
mailing list