resend: [PATCH] amba_pl022: Setup SPI configuration based on spi->mode
Linus Walleij
linus.walleij at stericsson.com
Tue Sep 14 10:45:57 EDT 2010
2010/9/13 Kevin Wells <kevin.wells at nxp.com>:
> SSP_CR0_MASK_SPH (SPHA) should use bit 7, not bit 6.
> Should be:
> SSP_WRITE_BITS(chip->cr0, tmp, SSP_CR0_MASK_SPH, 7);
>
>> +
>> SSP_WRITE_BITS(chip->cr0, chip_info->clk_freq.scr, SSP_CR0_MASK_SCR,
>> 8);
>> /* Loopback is available on all versions except PL023 */
That's it!
With this correction it starts working, so
Acked-by/Tested-by/Reviewed-by: Linus Walleij <linus.walleij at stericsson.com>
Please submit the whole patch series with corrections and my tag
so Grant can pick it up, and thanks for doing this because I think
it is a great improvement to the driver!
Yours,
Linus Walleij
More information about the linux-arm-kernel
mailing list