[PATCH 1/2] ARM: remove NR_IRQS in gic.c

Eric Miao eric.y.miao at gmail.com
Mon Sep 13 11:27:11 EDT 2010


On Mon, Sep 13, 2010 at 1:51 PM, Haojian Zhuang
<haojian.zhuang at marvell.com> wrote:
> NR_IRQS is used to specified irq numbers of one cpu. Although this macro
> is effective, it also blocks building multiple cpu architecutre into
> one image.
>
> After SPARSE IRQ is introduced, nr_irqs could also indicate irq numbers of
> one cpu architecture. Now use nr_irqs to replace NR_IRQS in gic.c.
>
> Signed-off-by: Haojian Zhuang <haojian.zhuang at marvell.com>
> Cc: Russell King <linux at arm.linux.org.uk>
> Cc: Eric Miao <eric.y.miao at gmail.com>

This is safe. I'm OK with this.

Acked-by: Eric Miao <eric.y.miao at gmail.com>


> ---
>  arch/arm/common/gic.c |    6 +++---
>  1 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/arch/arm/common/gic.c b/arch/arm/common/gic.c
> index 7dfa9a8..7f43eae 100644
> --- a/arch/arm/common/gic.c
> +++ b/arch/arm/common/gic.c
> @@ -191,7 +191,7 @@ static void gic_handle_cascade_irq(unsigned int irq, struct irq_desc *desc)
>                goto out;
>
>        cascade_irq = gic_irq + chip_data->irq_offset;
> -       if (unlikely(gic_irq < 32 || gic_irq > 1020 || cascade_irq >= NR_IRQS))
> +       if (unlikely(gic_irq < 32 || gic_irq > 1020 || cascade_irq >= nr_irqs))
>                do_bad_IRQ(cascade_irq, desc);
>        else
>                generic_handle_irq(cascade_irq);
> @@ -249,8 +249,8 @@ void __init gic_dist_init(unsigned int gic_nr, void __iomem *base,
>         * Limit this to either the architected maximum, or the
>         * platform maximum.
>         */
> -       if (max_irq > max(1020, NR_IRQS))
> -               max_irq = max(1020, NR_IRQS);
> +       if (max_irq > max(1020, nr_irqs))
> +               max_irq = max(1020, nr_irqs);
>
>        /*
>         * Set all global interrupts to be level triggered, active low.
> --
> 1.5.6.5
>
>



More information about the linux-arm-kernel mailing list