[PATCH 5/5] mfd: fix max8925 irq control bit incorrect setting

Samuel Ortiz sameo at linux.intel.com
Mon Sep 13 09:50:05 EDT 2010


Hi Haojian,

On Wed, Sep 08, 2010 at 09:44:36AM -0400, Haojian Zhuang wrote:
> From: Kevin Liu <kliu5 at marvell.com>
> 
> In max8925_irq_sync_unlock(), irq control bit is set at the same time.
> Zero means enabling irq, and one means disabling irq.
> 
> The original code is:
> 	irq_chg[0] &= irq_data->enable;
> 
> It should be changed to:
> 	irq_chg[0] &= ~irq_data->enable;
> 
> Otherwise, irq control bit is mess.
Ok, patch applied as well, thanks.
I am going to send this one for 2.6.36 inclusion.

Cheers,
Samuel.

-- 
Intel Open Source Technology Centre
http://oss.intel.com/



More information about the linux-arm-kernel mailing list