[PATCH] MMCI: use _cansleep GPIO functions

Rabin Vincent rabin at rab.in
Sat Sep 11 01:37:43 EDT 2010


On Fri, Sep 10, 2010 at 2:01 AM, Linus Walleij
<linus.walleij at stericsson.com> wrote:
> -               status = !!gpio_get_value(host->gpio_cd) ^ plat->cd_invert;
> +               status = gpio_get_value_cansleep(host->gpio_cd) ^
> +                       plat->cd_invert;

Why do you remove the double negation?  gpio_get_value*()
can return non-zero values, and we need to make it 1 for the
inversion xor to work.



More information about the linux-arm-kernel mailing list