[PATCH 5/7] ARM: don't expose CONFIG_ZRELADDR to the users

[Uwe Kleine-König]

Hello Mathieu,

On Tue, Sep 07, 2010 at 03:39:20PM -0700, Mathieu Rondonneau wrote:
> > 2010/9/4 Uwe Kleine-König <u.kleine-koenig at pengutronix.de>:
> >> On Fri, Sep 03, 2010 at 09:30:50PM +0800, Eric Miao wrote:
> >>> 2010/9/3 Uwe Kleine-König <u.kleine-koenig at pengutronix.de>
> >>> >
> >>> > This value is essential for booting a zImage and only depends on the
> >>> > memory layout of the machine to boot.  This value was specified in
> >>> > Makefile.boot before
> >>> >
> >>> >        e69edc79 (ARM: Auto calculate ZRELADDR and provide option for exceptions)
> >>> >
> >>> > and so wasn't available to change via .config.
> >>> >
> >>> > The only exception is bcmring that had a extra config for specifing the
> >>> > address used, which is removed in this commit, too, as it isn't used
> >>> > anymore since e69edc79.  This is the only machine that still gets a
> >>> > possibility to change CONFIG_ZRELADDR.
> >>>
> >>> This looks correct to me.
> >> That's an Ack?
> >>
> >
> > Ack.
> >
> 
> I think it should be:
> 
> --- a/arch/arm/mach-bcmring/Makefile.boot
> +++ b/arch/arm/mach-bcmring/Makefile.boot
> @@ -1,6 +1,5 @@
>  # Address where decompressor will be written and eventually executed.
>  #
>  # default to SDRAM
> -zreladdr-y      := $(CONFIG_BCM_ZRELADDR)
> +zreladdr-y      := $(CONFIG_ZRELADDR)
>  params_phys-y   := 0x00000800
> 
No, the variable zreladdr-y isn't used anymore, see path 7/7.

> 
> instead of
> 
> 
> --- a/arch/arm/mach-bcmring/Makefile.boot
> +++ b/arch/arm/mach-bcmring/Makefile.boot
> @@ -1,6 +1,5 @@
>  # Address where decompressor will be written and eventually executed.
>  #
>  # default to SDRAM
> -zreladdr-y      := $(CONFIG_BCM_ZRELADDR)
>  params_phys-y   := 0x00000800
> 
> 
> -Mathieu
There is no "Mathieu" in arch/arm/mach-bcmring/Makefile.boot to remove
:-)

Best regards
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |