[PATCH] ARM: PL330: Accept revisions of the dmac

Linus Walleij linus.ml.walleij at gmail.com
Tue Sep 7 17:39:02 EDT 2010


2010/9/7 Jassi Brar <jassisinghbrar at gmail.com>:

>> +#define amba_config(d) AMBA_CONFIG_BITS((d)->periphid)
>> +#define amba_rev(d)    AMBA_REV_BITS((d)->periphid)
>> +#define amba_manf(d)   AMBA_MANF_BITS((d)->periphid)
>> +#define amba_part(d)   AMBA_PART_BITS((d)->periphid)
>
> Sorry I missed that I need to read periph_id[0,3] regs and form
> Peripheral-ID from them,
> These macros do the reverse - extract fields from the Peripheral-ID.
> btw, you might want to close argument 'a' in parens as in ((a) & 0xfff) ?

Oh OK I'll fix the macros and put the patch for Russells review in the
patch tracker anyway, atleast getting the B105F00D magic defined
somewhere can be helpful.

Yours,
Linus Walleij



More information about the linux-arm-kernel mailing list