[PATCH 01/74] ST SPEAr: Padmux code Updated

[Jean-Christophe PLAGNIOL-VILLARD]

On 09:21 Tue 07 Sep     , viresh kumar wrote:
> On 9/7/2010 4:19 AM, Jean-Christophe PLAGNIOL-VILLARD wrote:
> >>  
> >> > -void spear300_pmx_init(void)
> >> > -{
> >> > -	spear_pmx_init(&pmx_driver, SPEAR300_SOC_CONFIG_BASE,
> >> > +	/* pmx initialization */
> >> > +	pmx_driver.base = ioremap(SPEAR300_SOC_CONFIG_BASE,
> >> >  			SPEAR300_SOC_CONFIG_SIZE);
> >> > +	if (pmx_driver.base) {
> >> > +		ret = pmx_register(&pmx_driver);
> >> > +		if (ret)
> >> > +			printk(KERN_ERR "padmux: registeration failed. err no"
> >> > +					": %d\n", ret);
> >> > +		iounmap(pmx_driver.base);
> > why unmap it?
> 
> pmx_register will actually enable all selected devices and configure padmux.
> After this we will never change device configuration again. So don't need
> this mapping.
so put a comment in the code

Best Regards,
J.