[PATCH 16/74] ST SPEAr: adding support for synopsis i2c designware
viresh kumar
viresh.kumar at st.com
Tue Sep 7 00:02:22 EDT 2010
Jean,
Thanks for reviewing our patches. Really appreciate your effort.
On 9/7/2010 4:42 AM, Jean-Christophe PLAGNIOL-VILLARD wrote:
>> > @@ -501,6 +510,9 @@ static struct clk_lookup spear_clk_lookups[] = {
>> > { .dev_id = "adc", .clk = &adc_clk},
>> > { .dev_id = "ssp", .clk = &ssp_clk},
>> > { .dev_id = "gpio", .clk = &gpio_clk},
>> > +#ifdef CONFIG_MACH_SPEAR320
>> > + { .dev_id = "i2c_designware.1", .clk = &i2c1_clk},
>> > +#endif
> how about split this file in 2
> one for 320 and one for 310 so we can avoid all this ifdef
There was a mistake in this patch series. As you can see in the last patches,
we worked on single image solution for spear*xx family. When we select all
machines then all clocks are getting registered. which is wrong?
I have corrected it in my local repo. Now i have created clk_lookup arrays
for individual machines and one for common clk structures. So you will not
find this mess finally in V2 release.
thanks
viresh.
More information about the linux-arm-kernel
mailing list