[PATCH 0/2] ARM: factorise CPU hotplug code

Russell King - ARM Linux linux at arm.linux.org.uk
Mon Sep 6 04:56:50 EDT 2010


On Mon, Sep 06, 2010 at 09:15:57AM +0200, Sundar R IYER wrote:
> Hi Santosh,
> 
> >-----Original Message-----
> >From: Shilimkar, Santosh [mailto:santosh.shilimkar at ti.com]
> 
> >Generic Approach seems to be good but I think this might complicate few
> >scenario's regarding how _A_ platform wants to handle the hotplug.
> >
> 
> Yes. But the functions cpu_enter_lowpower and cpu_leave_lowpower()
> are still preserved in platform specific files. Only the top helpers
> are moved out.
>
> So, platforms can still work out their custom low power mode
> implementations; which I believe can vary according to the
> implementation of (say independent) power domains for each/
> multiple cores.

So what if a platform wants to completely power down a CPU?

You'd want to implement it such that platform_cpu_die() does all
the shutdown of the CPU except for power-off, and platform_cpu_kill()
waits for that to complete before turning power off.

With platform_cpu_kill() and platform_cpu_die() moved into generic
code, you can no longer do this.

Lastly, what if you want to allow CPU0 to be offlined, which is
possible, though its wake-up is a little more complex because it
must not be allowed to go through its normal boot?



More information about the linux-arm-kernel mailing list