[PATCH] MMC: move regulator handling closer to core v2
Linus Walleij
linus.ml.walleij at gmail.com
Sun Sep 5 05:05:33 EDT 2010
2010/9/4 Adrian Hunter <adrian.hunter at nokia.com>:
> One of our contractors had a look at the patch and had this comment:
>
> One comment/question:
> /host/mmci.c in function
> "static int __devexit mmci_remove(struct amba_device *dev)" there is code:
> if (regulator_is_enabled(host->vcc))
> regulator_disable(host->vcc);
> should "ret = mmc_regulator_set_ocr(mmc, host->vcc, 0);" be added here?
Good catch!
Since it's in the remove() we can't do much about the return value from that
call but we should sure use the _set_ocr() so fixed it and pushed v3.
Yours,
Linus Walleij
More information about the linux-arm-kernel
mailing list