[PATCH] ARM: perf: fix event validation

Will Deacon will.deacon at arm.com
Thu Sep 2 04:33:50 EDT 2010


Hi Jamie,

> On Wed, Sep 01, 2010 at 01:11:22PM +0100, Will Deacon wrote:
> > The validate_event function in the ARM perf events backend has the
> > following problems:
> >
> > 1.) Events that are disabled count towards the cost.
> > 2.) Events associated with other PMUs [for example, software events or
> >     breakpoints] do not count towards the cost, but do fail validation,
> >     causing the group to fail.
> >
> > This patch changes validate_event so that it ignores events in the
> > PERF_EVENT_STATE_OFF state or that are scheduled for other PMUs.
> >
> > Cc: Jamie Iles <jamie.iles at picochip.com>
> > Reported-by: Pawel Moll <pawel.moll at arm.com>
> > Signed-off-by: Will Deacon <will.deacon at arm.com>
> > ---
> >
> > Resend with correct spelling of Pawel's email address on CC.
> > Jamie - are you ok with this fix?
> Yes, looks good to me.
> 
> Acked-by: Jamie Iles <jamie.iles at picochip.com>

Thanks for this. Submitted as 6352/1.

Will





More information about the linux-arm-kernel mailing list